Project

General

Profile

Enhancement(機能追加・改善) #1329

Change opMailSend::sendTemplateMail() to not use super global template

Added by Shogo Kawahara about 10 years ago. Updated about 10 years ago.

Status:
Fixed(完了)
Priority:
Normal(通常)
Target version:
Start date:
2010-07-13
Due date:
% Done:

100%


Description

Overview

Changes opMailSend::sendTemplateMail() to not use super global template

( opMailSend::sendTemplateMail() を super global template = ./templates/* を使わないように変える)


Related issues

Related to OpenPNE 3 - Bug(バグ) #1304: Mail templates for mobile are defective (モバイル版のメールテンプレートに不備がある) Fixed(完了) 2010-07-07
Related to OpenPNE 3 - Bug(バグ) #1309: Unused template files are existing in mobile_mail_frontend (使われていない不要なメールテンプレートが存在している) Fixed(完了) 2010-07-08
Related to OpenPNE 3 - Bug(バグ) #1038: 携帯版の退会処理で500エラー Invalid(無効) 2010-05-10

Associated revisions

Revision cbe0ffe4 (diff)
Added by Shogo Kawahara about 10 years ago

changed opMailSend::sendTemplateMail() to not use super globl template (refs #1329)

Revision b2d1f593 (diff)
Added by Shogo Kawahara about 10 years ago

removed opNotificationMailTemplateLoaderDatabase, added opNotificationMailTemplateLoaderConfigSample (refs #1329)

Revision d7cc88ac (diff)
Added by Shogo Kawahara about 10 years ago

removed super global templates (fixes #1329)

Revision ae11e268 (diff)
Added by Shogo Kawahara about 10 years ago

removed opNotificationMailTemplateLoaderDatabase (fixes #1329)

History

#1 Updated by Shogo Kawahara about 10 years ago

  • Assignee set to Shogo Kawahara
  • Target version set to OpenPNE 3.6beta1

#2 Updated by Shogo Kawahara about 10 years ago

  • Status changed from New(新規) to Pending Fixing(修正待ち)

#3 Updated by Shogo Kawahara about 10 years ago

  • Status changed from Pending Fixing(修正待ち) to Accepted(着手)

#4 Updated by Shogo Kawahara about 10 years ago

  • Status changed from Accepted(着手) to Pending Review(レビュー待ち)
  • % Done changed from 0 to 50

#5 Updated by Rimpei Ogawa about 10 years ago

  • Status changed from Pending Review(レビュー待ち) to Rejected(差し戻し)

NotificationMailTable::fetchTemplate() の中で mail_template.yml の内容からテンプレートを取得する処理がありますが、これを opNotificationMailTemplateLoaderDatabase という名前の Loader の中でやっているのは不適切です。Loader を分割するか、名前を変更するかのどちらかをすべきです。

また、使わなくなったスーパーグローバルのテンプレートファイルは削除しないと混乱のもととなるでしょう。

#6 Updated by Shogo Kawahara about 10 years ago

  • Status changed from Rejected(差し戻し) to Pending Review(レビュー待ち)

更新履歴 d7cc88ac2ff918cd93bdd7ff5012bc3a7853cb84 で適用されました。

#7 Updated by Rimpei Ogawa about 10 years ago

  • Status changed from Pending Review(レビュー待ち) to Rejected(差し戻し)

lib/util/opNotificationMailTemplateLoaderDatabase.class.php が不要になっているので削除してください。

#8 Updated by Shogo Kawahara about 10 years ago

  • Status changed from Rejected(差し戻し) to Accepted(着手)

#9 Updated by Shogo Kawahara about 10 years ago

  • Status changed from Accepted(着手) to Pending Review(レビュー待ち)

更新履歴 ae11e268f8bf6ae5f7f983eb7ba1edca39fd1572 で適用されました。

#10 Updated by Rimpei Ogawa about 10 years ago

  • Status changed from Pending Review(レビュー待ち) to Pending Testing(テスト待ち)
  • % Done changed from 50 to 70

#11 Updated by Kousuke Ebihara about 10 years ago

  • Status changed from Pending Testing(テスト待ち) to Fixed(完了)
  • % Done changed from 70 to 100

Also available in: Atom PDF