Project

General

Profile

Bug(バグ) #1463

[api] "filterBy=hasApp" parameter of PersonAPI doesn't work

Added by Shogo Kawahara over 9 years ago. Updated about 9 years ago.

Status:
Fixed(完了)
Priority:
High(高め)
Target version:
Start date:
2010-08-02
Due date:
% Done:

100%

3.6 で発生するか:
Yes
[QA]バグ通知済:
No
3.8 で発生するか:
Unknown (未調査)

Description

Overview

"filterBy=hasApp" parameter of PersonAPI doesn't work

Causes

The DQL in "lib/util/opJsonDbOpensocialService.class.php" is wrong.

diff --git a/lib/util/opJsonDbOpensocialService.class.php b/lib/util/opJsonDbOpensocialService.class.php
index e0d4597..9adb0cf 100644
--- a/lib/util/opJsonDbOpensocialService.class.php
+++ b/lib/util/opJsonDbOpensocialService.class.php
@@ -48,7 +48,7 @@ class opJsonDbOpensocialService implements ActivityService, PersonService, AppDa
       if (CollectionOptions::HAS_APP_FILTER === $options->getFilterBy() && $token->getAppId())
       {
         $memberApplications = Doctrine::getTable('MemberApplication')->createQuery()
-          ->where('application_id', $token->getAppId())
+          ->where('application_id = ?', $token->getAppId())
           ->execute();
         if (count($memberApplications))
         {

Way to fix

Fix DQL.


Related issues

Related to opOpenSocialPlugin - Backport(バックポート) #1464: [api] "filterBy=hasApp" parameter of PersonAPI doesn't work Fixed(完了) 2010-08-02
Related to opOpenSocialPlugin - Backport(バックポート) #1465: [api] "filterBy=hasApp" parameter of PersonAPI doesn't work Fixed(完了) 2010-08-02

Associated revisions

Revision 8056327b (diff)
Added by Shogo Kawahara over 9 years ago

fixed DQL in opJsonDbOpensocialService for filterBy parameter of PersonAPI (fixes #1463)

History

#1 Updated by Shogo Kawahara over 9 years ago

  • Status changed from New(新規) to Pending Fixing(修正待ち)
  • Priority changed from Normal(通常) to High(高め)

#2 Updated by Anonymous over 9 years ago

  • Status changed from Pending Fixing(修正待ち) to Pending Review(レビュー待ち)
  • % Done changed from 0 to 50

更新履歴 8056327b817259a07030fa4f8f1e05bab5a1096d で適用されました。

#3 Updated by Kousuke Ebihara over 9 years ago

  • 3.6 で発生するか set to Yes

#4 Updated by Shogo Kawahara over 9 years ago

パフォーマンス上の問題が発生していますが、別問題とします。

http://redmine.openpne.jp/issues/1556

#5 Updated by Shogo Kawahara about 9 years ago

  • Status changed from Pending Review(レビュー待ち) to Fixed(完了)
  • % Done changed from 50 to 100

Also available in: Atom PDF