Project

General

Profile

Bug(バグ) #1869

テスト用タスクで無駄な処理がある

Added by Rimpei Ogawa about 12 years ago. Updated over 11 years ago.

Status:
Fixed(完了)
Priority:
Normal(通常)
Assignee:
Target version:
Start date:
2011-01-14
Due date:
% Done:

100%

3.6 で発生するか:
[QA]バグ通知済:
No
3.8 で発生するか:
Unknown (未調査)

Description

opDiaryPluginConfiguration::filterPluginOnlyTestFiles() で filterTestFiles($event, array()) とすればその後の処理は不要と思われる(要検証)

現状

  public function filterPluginOnlyTestFiles(sfEvent $event, $files)
  {
    $files = $this->filterTestFiles($event, $files);

    foreach ($files as $key => $file)
    {
      if (false === strpos($file, $this->rootDir))
      {
        unset($files[$key]);
      }
    }

    return $files;
  }

Associated revisions

Revision aa30b651 (diff)
Added by Rimpei Ogawa over 11 years ago

fix test (refs #1869)

Revision 4f0ceddd (diff)
Added by Rimpei Ogawa over 11 years ago

remove useless code from opDiaryPluginConfiguration::filterPluginOnlyTestFiles() (refs #1869)

History

#1 Updated by Rimpei Ogawa about 12 years ago

  • Target version set to v1.3.2

#2 Updated by Rimpei Ogawa over 11 years ago

  • Status changed from New(新規) to Accepted(着手)

#3 Updated by Rimpei Ogawa over 11 years ago

  • Status changed from Accepted(着手) to Fixed(完了)
  • % Done changed from 0 to 100

Also available in: Atom PDF