Project

General

Profile

Bug（バグ） #221

Unit test is bad quality (ユニットテストが粗悪である)

Added by Shogo Kawahara over 10 years ago. Updated over 10 years ago.

Status:
Fixed（完了）
Priority:
Normal（通常）
Assignee:
Shogo Kawahara
Target version:
OpenPNE 3.2beta1
Start date:
2009-11-10
Due date:
% Done:

100%

3.6 で発生するか:
Unknown (未調査)
3.8 で発生するか:
Unknown (未調査)

Description

Unit test is bad quality.
It aims at the coverage of 80% of the model classes.

ユニットテストが粗悪である。
modelに関して言うと、3.0.x時代のPropelの為のテストが残され、さらに移行後の物でも極めて低いカバレッジである。
このチケットではmodelについての、カバレッジを80%以上を目指す。

Related issues

Related to OpenPNE 3 - Bug（バグ） #141: Unit test and functional test are bad quality (ユニットテストと機能テストが粗悪である) Invalid（無効） 2009-11-02

Associated revisions

Revision af9efe6e (diff)
Added by Shogo Kawahara over 10 years ago

fixed test of MemberProfileTableTest (refs #221)

Revision c3541ab9 (diff)
Added by Shogo Kawahara over 10 years ago

added test of MemberProfile (refs #221)

Revision e5048560 (diff)
Added by Shogo Kawahara over 10 years ago

added unit test of MemberConfig and deleted unnecessary file (refs #221)

Revision 2c998e46 (diff)
Added by Shogo Kawahara over 10 years ago

added some unit tests of model (refs #221)

Revision 1632d16e (diff)
Added by Shogo Kawahara over 10 years ago

added test of SnsConfig (refs #221)

Revision 45a399e4 (diff)
Added by Shogo Kawahara over 10 years ago

added test of CommunityCategory (refs #221)

Revision 8fb9fe96 (diff)
Added by Shogo Kawahara over 10 years ago

added test of CommunityConfig and deleted unnecessary files (refs #221)

Revision 79102b90 (diff)
Added by Shogo Kawahara over 10 years ago

added test of Navigation model (refs #221)

Revision 00831b85 (diff)
Added by Shogo Kawahara over 10 years ago

added test of Blacklist model (refs #221)

Revision 4fb1dc7c (diff)
Added by Shogo Kawahara over 10 years ago

added tests of oauth concerned model (refs #221)

Revision 3c32cbaf (diff)
Added by Shogo Kawahara over 10 years ago

added tests of Gadget and GadgetConfig (refs #221)

Revision afacb35e (diff)
Added by Shogo Kawahara over 10 years ago

added test of NotificationMail model (refs #221)

Revision 573c659c (diff)
Added by Shogo Kawahara over 10 years ago

added test of SnsTerm model (refs #221)

Revision 136f3882 (diff)
Added by Shogo Kawahara over 10 years ago

added test of OpenIDTrstLogTable (refs #221)

Revision 57fe83a8 (diff)
Added by Shogo Kawahara over 10 years ago

added tests of banner concerned model (refs #221)

Revision 32d70cf4 (diff)
Added by Shogo Kawahara over 10 years ago

fixed test of Gadget (refs #221)

Revision 92bc0440 (diff)
Added by Shogo Kawahara over 10 years ago

added some test datas (refs #221)

Revision 20cab1ab (diff)
Added by Kousuke Ebihara over 10 years ago

changed the executing doctrine task to be with "application" option and "env" option (refs #221)

Revision 8614c71e (diff)
Added by Kousuke Ebihara over 10 years ago

fixed coding standard error; a variable name is not camelCased (refs #221)

History

#1 Updated by Shogo Kawahara over 10 years ago

  • Status changed from Pending Fixing（修正待ち） to Invalid（無効）

ユニットテストと機能テストを別々のチケットに分けました。

#2 Updated by Shogo Kawahara over 10 years ago

  • Status changed from Invalid（無効） to Pending Fixing（修正待ち）

#3 Updated by Shogo Kawahara over 10 years ago

  • Status changed from Pending Fixing（修正待ち） to Accepted（着手）

#4 Updated by Shogo Kawahara over 10 years ago

  • Assignee set to Shogo Kawahara

#5 Updated by Shogo Kawahara over 10 years ago

  • % Done changed from 0 to 10

#6 Updated by Kousuke Ebihara over 10 years ago

  • Target version changed from OpenPNE 3.1.5 to OpenPNE 3.2beta1

ユニットテストなど品質改善のための努力は 3.2beta1 に回しましょう。

#7 Updated by Shogo Kawahara over 10 years ago

  • % Done changed from 10 to 20

#8 Updated by Shogo Kawahara over 10 years ago

  • % Done changed from 20 to 60

#9 Updated by Shogo Kawahara over 10 years ago

  • Status changed from Accepted（着手） to Pending Review（レビュー待ち）
  • % Done changed from 60 to 80

現時点のモデルにおける全テストのカバレッジを８０％以上にしました。

#10 Updated by Kousuke Ebihara over 10 years ago

  • Status changed from Pending Review（レビュー待ち） to Fixed（完了）
  • % Done changed from 80 to 100

Also available in: Atom PDF