Project

General

Profile

Bug(バグ) #2618

pc_frontend の test で opWebResponse を利用しないことによるテスト阻害

Added by Shogo Kawahara almost 8 years ago. Updated over 2 years ago.

Status:
Won't fix(対応せず)
Priority:
Urgent(急いで)
Target version:
Start date:
2011-11-23
Due date:
% Done:

0%

3.6 で発生するか:
Unknown (未調査)
3.8 で発生するか:
Unknown (未調査)

Description

Overview

pc_frontend の test に sfWebResponse が利用されており、
functional test にて warning が発生する

> application/add
# post /member/login/authMode/MailAddress
not ok 1 - last request threw an uncaught exception sfException: Call to undefined method sfWebResponse::generateMobileUidCookie.

Causes

#1113 の変更によるものであり、functional test について配慮されていない。

Way to fix

pc_frontend の factories.yml の修正
-> (影響範囲) テスト関連

Appendix

他のアプリケーションについては、当問題は発生しない。


Related issues

Related to OpenPNE 3 - Backport(バックポート) #3160: pc_frontend の test で opWebResponse を利用しないことによるテスト阻害 Fixed(完了) 2011-11-23
Related to OpenPNE 3 - Backport(バックポート) #3450: pc_frontend の test で opWebResponse を利用しないことによるテスト阻害 Fixed(完了) 2011-11-23
Related to OpenPNE 3 - Task(タスク) #3403: OpenPNE の既存のテストコードが正常に動作するように修正を行う Invalid(無効) 2012-02-02
Related to OpenPNE 3 - Backport(バックポート) #3470: pc_frontend の test で opWebResponse を利用しないことによるテスト阻害 Invalid(無効) 2011-11-23

Associated revisions

Revision 5baea5fb (diff)
Added by Shogo Kawahara almost 8 years ago

fixed factries.yml for pc_frontend, because test can't pass by the response's configuration (fixes #2618)

History

#1 Updated by Shogo Kawahara almost 8 years ago

  • Description updated (diff)

#2 Updated by Shogo Kawahara almost 8 years ago

1..43

application/add

  1. post /member/login/authMode/MailAddress
    not ok 1 - last request threw an uncaught exception sfException: Call to undefined method sfWebResponse::generateMobileUidCookie.
  2. Failed test (./lib/vendor/symfony/lib/test/sfTestFunctionalBase.class.php at line 425)

#3 Updated by Shogo Kawahara almost 8 years ago

  • Description updated (diff)

#4 Updated by Shogo Kawahara almost 8 years ago

  • Description updated (diff)

#5 Updated by Shogo Kawahara almost 8 years ago

  • Status changed from New(新規) to Pending Review(レビュー待ち)
  • % Done changed from 0 to 50

更新履歴 5baea5fb0f7ffd6bc7f3a4429f7da8209015fbbc で適用されました。

#6 Updated by Shouta Kashiwagi over 7 years ago

  • Target version changed from OpenPNE 3.7.0 to 252

#7 Updated by Youichi Kimura over 7 years ago

  • Priority changed from Normal(通常) to Urgent(急いで)

#8 Updated by Shouta Kashiwagi over 7 years ago

  • Target version changed from 252 to OpenPNE 3.8beta1

#9 Updated by Shogo Kawahara over 7 years ago

更新履歴 6a707421a63695a22ccf8e358144538bf8bf20a7 で適用されました。

#10 Updated by Yuma Sakata over 7 years ago

  • Target version changed from OpenPNE 3.8beta1 to OpenPNE 3.8.x
  • 3.6 で発生するか set to Unknown (未調査)
  • 3.4 で発生するか set to Unknown (未調査)

#11 Updated by Yuya Watanabe over 7 years ago

  • Target version changed from OpenPNE 3.8.x to OpenPNE 3.8.1

#12 Updated by Yuya Watanabe over 7 years ago

  • Status changed from Pending Review(レビュー待ち) to Pending Testing(テスト待ち)
  • % Done changed from 50 to 70

該当テストにおいて対象のメッセージが発生しないことを確認.

$ cd plugins/opOpenSocialPlugin
$ php test/functional/pc_frontend/applicationActionsTest.php
1..43
> application/add
# post /member/login/authMode/MailAddress
# get application/add/4
ok 1 - all of value of ApplicationTranslation.title are escaped.
# post application/add/4
ok 2 - message about CSRF token exists
> application/canvas
# post /member/login/authMode/MailAddress
# get application/canvas/5
ok 3 - all of value of ApplicationTranslation.title are escaped.
> application/delete
# get application/delete/4
ok 4 - all of value of ApplicationTranslation.title are escaped.
# post application/delete/4
ok 5 - message about CSRF token exists
> application/deleteConsumerSecret
# get application/deleteConsumerSecret/4
ok 6 - all of value of ApplicationTranslation.title are escaped.
...

#13 Updated by Yuya Watanabe over 7 years ago

  • Target version changed from OpenPNE 3.8.1 to OpenPNE 3.9.0-old

!!

#14 Updated by kaoru n over 4 years ago

  • 3.8 で発生するか set to Unknown (未調査)

#15 Updated by isao sano over 2 years ago

  • Status changed from Pending Testing(テスト待ち) to Won't fix(対応せず)
  • % Done changed from 70 to 0

OpenPNE 3.8.1 にて対応済みであったため、対応せずとします。

Also available in: Atom PDF