Project

General

Profile

Backport(バックポート) #3659

[PATCH] 一部のファイルに不要な実行権限が設定されている

Added by isao sano about 7 years ago. Updated about 7 years ago.

Status:
Fixed(完了)
Priority:
Normal(通常)
Assignee:
Target version:
Start date:
2014-07-15
Due date:
% Done:

100%


Description

現象

直接実行できないphpファイルや画像ファイルなどに実行可能権限が設定されています。

修正内容

ソースツリー内にELFファイルは存在しないため、ファイルの一行目がシバン行 (先頭が「#!」で開始) であるか否かで実行権限を設定します

find * -type f ! -regex '.*\.git.*' -print0 | xargs -0r -Ifile sh -c 'head -n1 file | grep -q "^#!" && chmod +x file || chmod -x file'

Related issues

Copied from OpenPNE 3 - Bug(バグ) #1839: [PATCH] 一部のファイルに不要な実行権限が設定されている Won't fix(対応せず) 2010-12-09

Associated revisions

Revision 5bd156b4 (diff)
Added by 誠二 天重 about 7 years ago

fix the permissions of file that are marked unnecessarily as executable (fixes #3659, BP from #1839)

Revision d464a100 (diff)
Added by 誠二 天重 about 7 years ago

Removed unnecessary executable file permission. (refs #3659, BP from #1839)

History

#1 Updated by isao sano about 7 years ago

  • Copied from Bug(バグ) #1839: [PATCH] 一部のファイルに不要な実行権限が設定されている added

#2 Updated by 誠二 天重 about 7 years ago

  • Status changed from New(新規) to Pending Review(レビュー待ち)
  • Assignee set to 誠二 天重
  • % Done changed from 0 to 50

#3 Updated by Shinichi Urabe about 7 years ago

  • Status changed from Pending Review(レビュー待ち) to Rejected(差し戻し)

実行権限があるファイルが残っています

data/upgrade/2/opUpgradeFrom2MemberImageCleanupStrategy.class.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/BuildLogger.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/lib/Zip.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/listener/XmlLogger.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/MailTask.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/ZipTask.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/coverage/CoverageMerger.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/coverage/CoverageReportTask.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/coverage/CoverageReportTransformer.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/coverage/CoverageSetupTask.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/dbdeploy/DbDeployTask.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/ioncube/IoncubeComment.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/ioncube/IoncubeEncoderTask.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/ioncube/IoncubeLicenseTask.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/phpdoc/PhingPhpDocumentorSetup.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/phpdoc/PhpDocumentorExternalTask.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/phpdoc/PhpDocumentorTask.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/phpunit/BatchTest.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/phpunit/FormatterElement.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/phpunit/PHPUnitReportTask.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/phpunit/PHPUnitTask.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/phpunit/PHPUnitTestRunner.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/phpunit/PHPUnitUtil.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/phpunit/phpunit2/PHPUnit2ResultFormatter.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/phpunit/phpunit2/PlainPHPUnit2ResultFormatter.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/phpunit/phpunit2/SummaryPHPUnit2ResultFormatter.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/phpunit/phpunit2/XMLPHPUnit2ResultFormatter.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/svn/SvnBaseTask.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/svn/SvnExportTask.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/tasks/ext/svn/SvnLastRevisionTask.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/util/ExtendedFileStream.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/util/LogWriter.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/phing/util/PathTokenizer.php
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/propel-generator/bin/propel-gen.bat
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/propel-generator/pear/pear-propel-gen
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/propel-generator/resources/xsd/custom_datatypes.xsd
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/propel-generator/resources/xsd/database.xsd
lib/vendor/symfony/lib/plugins/sfPropelPlugin/lib/vendor/propel-generator/resources/xsl/database.xsl
lib/vendor/symfony/lib/plugins/sfPropelPlugin/web/images/asc.png
lib/vendor/symfony/lib/plugins/sfPropelPlugin/web/images/default.png
lib/vendor/symfony/lib/plugins/sfPropelPlugin/web/images/delete.png
lib/vendor/symfony/lib/plugins/sfPropelPlugin/web/images/desc.png
lib/vendor/symfony/lib/plugins/sfPropelPlugin/web/images/edit.png
lib/vendor/symfony/lib/plugins/sfPropelPlugin/web/images/error.png
lib/vendor/symfony/lib/plugins/sfPropelPlugin/web/images/first.png
lib/vendor/symfony/lib/plugins/sfPropelPlugin/web/images/last.png
lib/vendor/symfony/lib/plugins/sfPropelPlugin/web/images/list.png
lib/vendor/symfony/lib/plugins/sfPropelPlugin/web/images/new.png
lib/vendor/symfony/lib/plugins/sfPropelPlugin/web/images/next.png
lib/vendor/symfony/lib/plugins/sfPropelPlugin/web/images/previous.png
lib/vendor/symfony/lib/plugins/sfPropelPlugin/web/images/tick.png

#4 Updated by 誠二 天重 about 7 years ago

  • Status changed from Rejected(差し戻し) to Pending Review(レビュー待ち)

https://github.com/openpne/OpenPNE3/pull/161
プルリクエストに追加しました。

#5 Updated by Shinichi Urabe about 7 years ago

  • Status changed from Pending Review(レビュー待ち) to Pending Testing(テスト待ち)
  • % Done changed from 50 to 70

レビューOKです

#6 Updated by isao sano about 7 years ago

  • Status changed from Pending Testing(テスト待ち) to Pending Merge(マージ待ち)
  • % Done changed from 70 to 80

単体試験完了しました。
問題ありません。

#7 Updated by 誠二 天重 about 7 years ago

  • Status changed from Pending Merge(マージ待ち) to Fixed(完了)
  • % Done changed from 80 to 100

更新履歴 5bd156b4845b16ddfc9c323a652366ba306795e9 で適用されました。

Also available in: Atom PDF