Project

General

Profile

Backport(バックポート) #3891

小窓機能 google map が機能していないので修正してほしい

Added by isao sano over 4 years ago. Updated over 4 years ago.

Status:
Fixed(完了)
Priority:
Normal(通常)
Assignee:
Target version:
Start date:
2016-03-09
Due date:
% Done:

100%


Description

概要

http://www.openpne.jp/cmd/list/#maps.google.co.jp

GoogleマップはURLではなく、右端にある【このページのリンク】→【このリンクをメールに貼り付けて地図を共有できます】のURLを貼ることで表示することができます。

と説明されているが、現在のgooglemapにある「地図を共有または埋め込む」から取得できるURLはアドレスバーに表示されているものと同じであり、このURLを使っても地図は表示されない

仕様

仕様がある場合、仕様を記入


Related issues

Related to OpenPNE 3 - Enhancement(機能追加・改善) #3775: 小窓機能 google map が機能していないので修正してほしい Won't fix(対応せず) 2015-02-10

Associated revisions

Revision 67b65ada (diff)
Added by isao sano over 4 years ago

Modified to be able to display the URL of the new format of the Googlemap (refs #3891, BP from #3775)

Revision 9f9f6d3d (diff)
Added by isao sano over 4 years ago

Modify to unified indentation (refs #3891, BP from #3775)

Revision f04931f2 (diff)
Added by isao sano over 4 years ago

Corresponding to a different pattern of URL (refs #3891, BP from #3775)

Revision 4e75c1b4 (diff)
Added by isao sano over 4 years ago

Change the way you get a unique value (refs #3891, BP from #3775)

Revision 8a154b4b (diff)
Added by isao sano over 4 years ago

Change the id matching pattern (refs #3891, BP from #3775)

Revision 09dbb6fc (diff)
Added by isao sano over 4 years ago

Delete the character of unnecessary regular expression (refs #3891, BP from #3775)

Revision 632d8216 (diff)
Added by isao sano over 4 years ago

Modify as quoted part does not match (refs #3891, BP from #3775)

Revision e9ca54f7 (diff)
Added by isao sano over 4 years ago

Modified to correctly match (refs #3891, BP from #3775)

Revision 5a61a4db
Added by Shinichi Urabe over 4 years ago

Merge pull request #324 from isaosano/t3891

Modified to be able to display the URL of the new format of the Googlemap (refs #3891, BP from #3775)

History

#1 Updated by isao sano over 4 years ago

#2 Updated by isao sano over 4 years ago

  • Status changed from New(新規) to Accepted(着手)

#3 Updated by isao sano over 4 years ago

  • Status changed from Accepted(着手) to Pending Review(レビュー待ち)
  • % Done changed from 0 to 50

https://github.com/openpne/OpenPNE3/pull/313
にてプルリクエストを行いました。
レビューお願いします。

#4 Updated by Shinichi Urabe over 4 years ago

  • Status changed from Pending Review(レビュー待ち) to Rejected(差し戻し)

https://redmine.openpne.jp/issues/3775#note-6 と同様の理由で差し戻し

#5 Updated by isao sano over 4 years ago

  • Status changed from Rejected(差し戻し) to Accepted(着手)
  • % Done changed from 50 to 0

#6 Updated by isao sano over 4 years ago

  • Status changed from Accepted(着手) to Pending Review(レビュー待ち)
  • % Done changed from 0 to 50

https://github.com/openpne/OpenPNE3/pull/324
にてプルリクエストをしました。
再度レビューお願いします。

#7 Updated by Shinichi Urabe over 4 years ago

  • Status changed from Pending Review(レビュー待ち) to Rejected(差し戻し)

#8 Updated by isao sano over 4 years ago

  • Status changed from Rejected(差し戻し) to Accepted(着手)
  • % Done changed from 50 to 0

#9 Updated by isao sano over 4 years ago

  • Status changed from Accepted(着手) to Pending Review(レビュー待ち)
  • % Done changed from 0 to 50

https://github.com/openpne/OpenPNE3/pull/324
に修正を追加しました。
再度レビューお願いします。

#10 Updated by Shinichi Urabe over 4 years ago

  • Status changed from Pending Review(レビュー待ち) to Pending Testing(テスト待ち)
  • % Done changed from 50 to 70

#11 Updated by isao sano over 4 years ago

https://github.com/openpne/OpenPNE3/pull/3124

Modify as quoted part does not match (refs #3891, BP from #3775) 
commit 632d821656a5b2f3dc181ed89a0d6ab0e87b9ec3

にて、' や " を含む部分がマッチしないように修正しました。
@ が先頭もしくは / の直後に来る場合のみマッチするようにしました。

#12 Updated by isao sano over 4 years ago

  • Status changed from Pending Testing(テスト待ち) to Pending Review(レビュー待ち)
  • % Done changed from 70 to 50

#13 Updated by Shinichi Urabe over 4 years ago

  • Status changed from Pending Review(レビュー待ち) to Rejected(差し戻し)

#14 Updated by isao sano over 4 years ago

  • Status changed from Rejected(差し戻し) to Accepted(着手)
  • % Done changed from 50 to 0

#15 Updated by isao sano over 4 years ago

note-13 の指摘を受けて修正しました。
https://github.com/openpne/OpenPNE3/pull/324

#16 Updated by isao sano over 4 years ago

  • Status changed from Accepted(着手) to Pending Review(レビュー待ち)
  • % Done changed from 0 to 50

#17 Updated by Shinichi Urabe over 4 years ago

  • Status changed from Pending Review(レビュー待ち) to Pending Testing(テスト待ち)
  • % Done changed from 50 to 70

#18 Updated by isao sano over 4 years ago

  • Status changed from Pending Testing(テスト待ち) to Pending Merge(マージ待ち)
  • % Done changed from 70 to 80

試験実施しました。問題ありません。

#19 Updated by Shinichi Urabe over 4 years ago

  • Status changed from Pending Merge(マージ待ち) to Fixed(完了)
  • % Done changed from 80 to 100

Also available in: Atom PDF