Project

General

Profile

Backport(バックポート) #1410

ActivityData::getBody() is too bad in template. ( ActivityData::getBody() はテンプレートで適切でない挙動をする )

Added by Shogo Kawahara about 11 years ago. Updated about 11 years ago.

Status:
Fixed(完了)
Priority:
Normal(通常)
Target version:
Start date:
2010-07-20
Due date:
% Done:

100%


Description

Overview (概要)

ActivityData::getBody() is too bad in template. ( ActivityData::getBody() はテンプレートで良くない挙動をする)

  • When body is re-wrote by "op_activity.filter_body", default of ActivityDataForm is re-wroted too.
  • Body is double-escaped by filter.
  • 本文が op_activity.filter_body によって書き換えられるとき、ActivityDataFormのデフォルト値も書き換えられます。
  • フィルタによって本文がダブルエスケープされることがあります。

Causes (原因)

  • Default of sfDoctrineForm depend on Doctrine_Record::get*.
  • In template, Doctrine_Record is comprehended sfOutputEscaperObjectDecorator.

Way to fix (修正方法)

  • To prevent double-escaping, filter move helper.

Related issues

Related to OpenPNE 3 - Bug(バグ) #1377: ActivityData::getBody() is too bad in template. ( ActivityData::getBody() はテンプレートで適切でない挙動をする ) Fixed(完了) 2010-07-20

Associated revisions

Revision c752487e (diff)
Added by tu nguyen ngoc about 11 years ago

removed ActivityData::getBody() and added op_activity_body_filter() of helper (fixes #1410, BP from #1377)

History

#1 Updated by Shogo Kawahara about 11 years ago

  • Assignee deleted (Shogo Kawahara)

#2 Updated by Rimpei Ogawa about 11 years ago

  • Target version changed from OpenPNE 3.6beta4 to OpenPNE 3.6beta5

#3 Updated by tu nguyen ngoc about 11 years ago

  • Status changed from New(新規) to Accepted(着手)
  • Assignee set to tu nguyen ngoc

#4 Updated by tu nguyen ngoc about 11 years ago

  • Status changed from Accepted(着手) to Pending Review(レビュー待ち)
  • % Done changed from 0 to 50

更新履歴 c752487e5660973672098fe210a16536472aff3f で適用されました。

#5 Updated by Kousuke Ebihara about 11 years ago

  • Status changed from Pending Review(レビュー待ち) to Pending Testing(テスト待ち)
  • % Done changed from 50 to 70

#6 Updated by Hiroki Mogi about 11 years ago

  • Status changed from Pending Testing(テスト待ち) to Fixed(完了)
  • % Done changed from 70 to 100

テストを実施しました。正常に動作していました。

Also available in: Atom PDF