Project

General

Profile

Backport(バックポート) #4095

Bug(バグ) #4093: api アプリケーションにおいて opI18n クラスが使用されていないため、SnsTerm が翻訳されない

api アプリケーションにおいて opI18n クラスが使用されていないため、SnsTerm が翻訳されない

Added by Shinichi Urabe over 7 years ago. Updated over 5 years ago.

Status:
Fixed(完了)
Priority:
Normal(通常)
Target version:
Start date:
2016-12-27
Due date:
% Done:

100%


Description

現象

#3596 の修正中に発覚

※ ただし、OpenPNE 3.8.x 以上で動く機能であるため、3.6.x で上記現象の再現はできない

原因

apps/api/config/factories.yml において opI18n クラスが使用される設定となっていない

修正内容

apps/api/config/factories.yml において opI18n クラスを使用する設定にし、
lib/i18n/opI18N.class.php において、 api アプリケーションの場合は、 pc_frontend の SnsTerm を使用するように設定

i18n-opMessagePlugin.png View (113 KB) Shinichi Urabe, 2016-12-27 19:46


Related issues

Copied from OpenPNE 3 - Backport(バックポート) #4094: api アプリケーションにおいて opI18n クラスが使用されていないため、SnsTerm が翻訳されない Fixed(完了) 2016-12-27

Associated revisions

Revision 66b9b8f5 (diff)
Added by Shinichi Urabe over 7 years ago

(refs #4095, BP from #4093) use opI18n class in api application.

Revision e2eea5d9 (diff)
Added by Shinichi Urabe over 7 years ago

(refs #4095, BP from #4093) add opI18N test case for api application.

Revision 8317a808 (diff)
Added by Shinichi Urabe over 7 years ago

(refs #4095, BP from #4093) use opI18n class in api application in template.

Revision 34db3c37 (diff)
Added by Shinichi Urabe over 7 years ago

(refs #4095, BP from #4093) Fix test case comment titleize (NG) -> fronting (OK)

Revision 37eb1add (diff)
Added by Shinichi Urabe over 7 years ago

(refs #4095, BP from #4093) Add ja_JP test case.

Revision c8954986
Added by kaoru n over 5 years ago

Merge pull request #406 from ShinichiU/t-4095

(refs #4095, BP from #4093) use opI18n class in api application.

History

#1 Updated by Shinichi Urabe over 7 years ago

#2 Updated by Shinichi Urabe over 7 years ago

  • Description updated (diff)
  • Status changed from New(新規) to Pending Review(レビュー待ち)
  • % Done changed from 0 to 50

#4 Updated by Youichi Kimura over 7 years ago

  • Status changed from Pending Review(レビュー待ち) to Rejected(差し戻し)

#4093-10 と同様の理由で差し戻します。

#5 Updated by Shinichi Urabe over 7 years ago

  • Status changed from Rejected(差し戻し) to Pending Review(レビュー待ち)

https://github.com/openpne/OpenPNE3/pull/406 テストケースを追加しました

#6 Updated by Youichi Kimura over 7 years ago

  • Status changed from Pending Review(レビュー待ち) to Rejected(差し戻し)

#4093-13 と同様の理由により差し戻します。

#7 Updated by Shinichi Urabe over 7 years ago

  • Status changed from Rejected(差し戻し) to Pending Merge(マージ待ち)
  • % Done changed from 50 to 80

https://github.com/openpne/OpenPNE3/pull/406#4093-13 の指摘を修正しました

#8 Updated by Youichi Kimura over 7 years ago

  • Status changed from Pending Merge(マージ待ち) to Rejected(差し戻し)
  • % Done changed from 80 to 50

#4093-15 と同様の理由で差し戻します。

#9 Updated by Shinichi Urabe over 7 years ago

  • Status changed from Rejected(差し戻し) to Pending Merge(マージ待ち)
  • % Done changed from 50 to 80

#10 Updated by Shinichi Urabe over 7 years ago

  • Status changed from Pending Merge(マージ待ち) to Rejected(差し戻し)
  • % Done changed from 80 to 50

#4093-17 に併せて日本語のテストケースも追加します

#11 Updated by Shinichi Urabe over 7 years ago

  • Status changed from Rejected(差し戻し) to Pending Merge(マージ待ち)
  • % Done changed from 50 to 80

https://github.com/openpne/OpenPNE3/pull/406 に日本語のテストケースを追加しました

#12 Updated by kaoru n about 7 years ago

  • Status changed from Pending Merge(マージ待ち) to Pending Review(レビュー待ち)
  • % Done changed from 80 to 50

#13 Updated by Youichi Kimura about 7 years ago

  • Description updated (diff)
  • Status changed from Pending Review(レビュー待ち) to Pending Testing(テスト待ち)
  • % Done changed from 50 to 70

レビューOKです

#14 Updated by kaoru n about 7 years ago

  • Target version changed from OpenPNE 3.6.x to OpenPNE 3.6.28

#15 Updated by kaoru n about 7 years ago

  • Target version changed from OpenPNE 3.6.28 to OpenPNE 3.6.x

#16 Updated by kaoru n almost 7 years ago

  • Target version changed from OpenPNE 3.6.x to OpenPNE 3.6.29

#17 Updated by Chiharu Nakajima almost 7 years ago

  • Status changed from Pending Testing(テスト待ち) to Pending Merge(マージ待ち)
  • % Done changed from 70 to 80

動作確認OKです

#18 Updated by kaoru n almost 7 years ago

  • Target version changed from OpenPNE 3.6.29 to OpenPNE 3.6.x

#19 Updated by kaoru n almost 6 years ago

  • Target version changed from OpenPNE 3.6.x to OpenPNE 3.6.33

#20 Updated by kaoru n almost 6 years ago

  • Target version changed from OpenPNE 3.6.33 to OpenPNE 3.6.x

#21 Updated by kaoru n over 5 years ago

  • Target version changed from OpenPNE 3.6.x to OpenPNE 3.6.34

#22 Updated by kaoru n over 5 years ago

  • Status changed from Pending Merge(マージ待ち) to Fixed(完了)
  • % Done changed from 80 to 100

マージしました

Also available in: Atom PDF